Skip to content

feat: Converted index.react_native.js to TS #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 26 commits into from
Closed

feat: Converted index.react_native.js to TS #581

wants to merge 26 commits into from

Conversation

ozayr-zaviar
Copy link
Contributor

Summary

  • Converted packages\optimizely-sdk\lib\index.react_native.js to TS

Test plan

  • All existing test cases on FSC and for index.react_native.js should pass

uzair-folio3 and others added 26 commits September 22, 2020 23:21
added declaration file for event builder
7b02917
added declaration file for notification center
3920a66
comments addressed: imports moved inside module and errorHandler corr…
d3db6d3 
…ected and linting fixed
comment addressed: seperate declaration file for event_helper event_h…
143379e 
…elper.d.ts
event_helpers module name and declaration file name corrected
51ad50b
event helper functions and interfaces removed from event builder module
e9d9ce6
EOL in event_helpers.d.ts
5ed0fe5
event_helper.d.ts linting fixed
ade1028
@msohailhussain
Merge branch 'master' into uzair/eb_declaration
fdc2193
@msohailhussain
Merge branch 'master' into uzair/nc_declaration
fcc31fd
@yavorona
Merge branch 'uzair/nc_declaration' into pnguen/optimizely-module-to-ts
600ea36
@yavorona
Fix imports`
59b7ce6
@yavorona
Merge branch 'uzair/eb_declaration' into pnguen/optimizely-module-to-ts
1ee33b1
@yavorona
Fix imports
2f4a24e
@yavorona
Draft: Convert optimizely module to ts
b7aa82c
@yavorona
Change ProjectConfigManager method to create ProjectConfigManager to …
e6eb70f 
…createProjectConfigManager for clarity and update unit tests
@yavorona
Convert more methods
9555710
@yavorona
Convert onReady
dd5fb2a
@yavorona
Fix imports and got to a working state
615ab27
@yavorona
Fix lint
f7803d6
@yavorona
Update tests
36d72c9
@yavorona
Add missing types
fc56d82
@yavorona
Fix maxQueueSize
1569d17
@yavorona
Temporary move LogTierV1EventProcessorConfig to shared_types to avoid…
6ebe2f9 
… Travis lint failure
@yavorona
fix Lint
e08bfab
converted index.react_native.js to ts
abf800a
@ozayr-zaviar
Copy link
Contributor Author

ozayr-zaviar commented Sep 28, 2020 •
edited
Loading

This PR is based on optimizely_module PR, before merging into master, we'll have to rebase once optimizely_module PR is merged.

@ozayr-zaviar ozayr-zaviar removed their assignment Sep 28, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 96.589% when pulling abf800a on uzair/react-conversion into 90c5fdb on master.

@raju-opti raju-opti deleted the uzair/react-conversion branch October 4, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ozayr-zaviar @coveralls @msohailhussain @yavorona