Skip to content

feat: Converted index.browser.js to TS #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 22 commits into from
Closed

feat: Converted index.browser.js to TS #585

wants to merge 22 commits into from

Conversation

ozayr-zaviar
Copy link
Contributor

@ozayr-zaviar ozayr-zaviar commented Oct 2, 2020 •
edited
Loading

Summary

  • Converted packages\optimizely-sdk\lib\index.browser.js to TS

Test plan

  • All existing unit tests should pass
  • All existing test cases on FSC should pass

uzair-folio3 and others added 22 commits September 28, 2020 12:41
@yavorona
added declaration file for notification center
bc99e5d
@yavorona
comment addressed: seperate declaration file for event_helper event_h…
5819fff 
…elper.d.ts
@yavorona
event_helpers module name and declaration file name corrected
a27a13c
@yavorona
EOL in event_helpers.d.ts
6cc5495
@yavorona
Convert Optimizely Module
687d620
@yavorona
Fix comments
0df41cf
@yavorona
Update formatting and add optional attribute sign
a2cefd7
@yavorona
Clean up
a86dc34
@yavorona
Address Matt's comments part 1
343518e
@yavorona
Address comment part2
b34d864
@yavorona
Incorporating commenta part 3
04b44cc
@yavorona
Incorporate comments part 4
90cd51c
@yavorona
Updating names of private methods
e8473a5
@yavorona
Update private methods
32faf70
@yavorona
Create configObj interface
289f2ea
@yavorona
Clean up
3b0ba96
@yavorona
Add back DatafileOptions
096f857
@yavorona
Create ProjectConfigManagerConfig interface
625da66
@yavorona
Fix LogTierV1EventProcessor compiler error without re-defining LogTie…
b76d534 
…rV1EventProcessorConfig
@yavorona
Fix EventTags to not except boolean
145838b
@yavorona
incporporating comments part 1
510bb95
converted index.browser.js to ts accroding to optimizely module
a1c7f47
@ozayr-zaviar ozayr-zaviar requested a review from a team as a code owner October 2, 2020 14:00
@ozayr-zaviar ozayr-zaviar marked this pull request as draft October 2, 2020 14:00
@ozayr-zaviar ozayr-zaviar removed their assignment Oct 2, 2020
@ozayr-zaviar ozayr-zaviar changed the title Uzair/browser js to ts conversion feat: Converted index.browser.js to TS Oct 2, 2020
@ozayr-zaviar
Copy link
Contributor Author

This PR is based on optimizely_module. This PR contains some issues due to parent PR. Need to rebase it once optimizely_module is merged.

@raju-opti raju-opti deleted the uzair/browser_js_to_ts_conversion branch October 4, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🤖 4 hrs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ozayr-zaviar @optimizely-codereview-bot @yavorona