fix: Allow using --isolatedModules flag in tsconfig by fixing exports in event_processor #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjc1283
approved these changes
Nov 4, 2020
| @@ -22,6 +22,6 @@ export function createEventProcessor( | |||
| return new LogTierV1EventProcessor(...args); | |||
| } | |||
|
|
|||
| export { EventProcessor, LocalStoragePendingEventsDispatcher } from '@optimizely/js-sdk-event-processor'; | |||
| export type { EventProcessor, LocalStoragePendingEventsDispatcher } from '@optimizely/js-sdk-event-processor'; | |||
There was a problem hiding this comment.
Suggest removing LocalStoragePendingEventsDispatcher - as we discussed, nothing is using it, and I got confused thinking this change would cause a problem.
Suggested change
| export type { EventProcessor, LocalStoragePendingEventsDispatcher } from '@optimizely/js-sdk-event-processor'; | |
| export type { EventProcessor } from '@optimizely/js-sdk-event-processor'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--isolatedModulesflag in tsconfig by fixing exports in event_processorTest plan
FSC and unit tests
Issues
SDK-issue 609