Skip to content

fix(Optimizely): Use any type for return value of setTimeout #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 12, 2020
Merged

fix(Optimizely): Use any type for return value of setTimeout #623

merged 3 commits into from
Nov 12, 2020

Conversation

mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented Nov 12, 2020

Summary

Fix for #622 . For the Node.js version of setTimeout, the return value isn't number, but Timeout. To allow this to typecheck regardless of whether the browser or Node.js version is used, set the type of readyTimeout to any.

Test plan

Existing tests

Issues

#622

@mjc1283 mjc1283 requested a review from a team as a code owner November 12, 2020 17:37
@coveralls
Copy link

coveralls commented Nov 12, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 96.706% when pulling 7888515 on mc/issue-622 into 058d0db on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.706% when pulling 67d211e on mc/issue-622 into 058d0db on master.

@mjc1283 mjc1283 merged commit 1fb0013 into master Nov 12, 2020
@mjc1283 mjc1283 deleted the mc/issue-622 branch November 12, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yavorona yavorona yavorona approved these changes

Assignees

@mjc1283 mjc1283

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjc1283 @coveralls @yavorona