Skip to content

fix: Refactor index.d.ts imports #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2020
Merged

fix: Refactor index.d.ts imports #625

merged 1 commit into from
Nov 16, 2020

Conversation

yavorona
Copy link
Contributor

Summary

  • Refactor lib/index.d.ts imports such that it only imports from shared_files.

Test plan

  • Unit tests

@yavorona yavorona requested a review from a team as a code owner November 13, 2020 00:16
@yavorona yavorona removed their assignment Nov 13, 2020
@coveralls
Copy link

coveralls commented Nov 13, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 96.707% when pulling b36f192 on pgnuen/refactor-declaration-file into 170ab61 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.706% when pulling b3d2e89 on pgnuen/refactor-declaration-file into 1fb0013 on master.

@yavorona yavorona force-pushed the pgnuen/refactor-declaration-file branch from b3d2e89 to b36f192 Compare November 13, 2020 22:05
mjc1283
mjc1283 approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@mjc1283 mjc1283 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yavorona ! LGTM

@yavorona yavorona merged commit a0157fd into master Nov 16, 2020
@yavorona yavorona deleted the pgnuen/refactor-declaration-file branch November 16, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

Assignees
No one assigned
Labels
🤖 8 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yavorona @coveralls @mjc1283 @optimizely-codereview-bot