Skip to content

fix: Move OptimizelyOptions interface to shared_types #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2020
Merged

fix: Move OptimizelyOptions interface to shared_types #629

merged 2 commits into from
Nov 21, 2020

Conversation

yavorona
Copy link
Contributor

Summary

  • Move OptimizelyOptions interface to shared_types to provide isolation from internal ts modules

Test plan

Existing unit tests

@yavorona yavorona requested a review from a team as a code owner November 20, 2020 18:10
@yavorona yavorona removed their assignment Nov 20, 2020
@coveralls
Copy link

coveralls commented Nov 20, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 96.71% when pulling 1e2b651 on pnguen/fix-optimizely-imports into 8028443 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.71% when pulling 1e2b651 on pnguen/fix-optimizely-imports into 8028443 on master.

@yavorona yavorona merged commit e8e71c9 into master Nov 21, 2020
@yavorona yavorona deleted the pnguen/fix-optimizely-imports branch November 21, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mjc1283 mjc1283 mjc1283 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🤖 4 hrs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yavorona @coveralls @mjc1283 @optimizely-codereview-bot