feat: Implement createUserContext for decide API #632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
requested changes
Dec 5, 2020
| } | ||
|
|
||
| getAttributes(): UserAttributes { | ||
| return this.attributes; |
There was a problem hiding this comment.
Can we return a copy of attributes?
The attributes can be changed by setAttribute while decide using it.
| }) { | ||
| this.optimizely = optimizely; | ||
| this.userId = userId; | ||
| this.attributes = attributes ?? {}; |
There was a problem hiding this comment.
Can we keep a copy of the given attributes here, so that any changes in the caller attributes after creating userContext are not reflected.
| }); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Can we have one more test validating that changing caller attributes after createUserContext is not reflected in the create userContext?
mjc1283
approved these changes
Dec 5, 2020
| @@ -189,6 +189,7 @@ export const DECISION_NOTIFICATION_TYPES = { | |||
| FEATURE_TEST: 'feature-test', | |||
| FEATURE_VARIABLE: 'feature-variable', | |||
| ALL_FEATURE_VARIABLES: 'all-feature-variables', | |||
| FLAG: 'flag', | |||
There was a problem hiding this comment.
Does this need to be added now, or a later PR?
There was a problem hiding this comment.
In the next pr. Will remove it from here. Thanks!
yavorona
force-pushed
the
pnguen/decide-api-optimizely-user-context
branch
from
5114c19 to
d83c3ec
Compare
yavorona
force-pushed
the
pnguen/decide-api-optimizely-user-context
branch
from
d83c3ec to
e4f595c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
createUserContextin optimizely clientOptimizelyUserContextclass and implementsetAttributemethoddecideConfigfor future decide API testingTest
Issues