feat: Implement IGNORE_USER_PROFILE_SERVICE flag in decide options #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavorona
force-pushed
the
pnguen/ignore-user-profile-service
branch
2 times, most recently
from
8944a95 to
c57e416
Compare
jaeopt
requested changes
Jan 13, 2021
| @@ -5621,6 +5621,50 @@ describe('lib/optimizely', function() { | |||
| ); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('with IGNORE_USER_PROFILE_SERVICE flag in decide options', function() { | |||
There was a problem hiding this comment.
This test looks good. Can you do the same test with "IGNORE_USER_PROFILE" in defaultDecideOptions?
| * @param {string} experimentKey | ||
| * @param {string} userId | ||
| * @param {Object} attributes | ||
| * @param {OptimizelyDecideOptions[]} options Decide options |
There was a problem hiding this comment.
Fix this type. Not an array.
| var shouldIgnoreUPS = options[OptimizelyDecideOptions.IGNORE_USER_PROFILE_SERVICE]; | ||
|
|
||
| // check for sticky bucketing if decide options do not include shouldIgnoreUPS | ||
| if (!shouldIgnoreUPS) { |
There was a problem hiding this comment.
This should be used to bypass "saveUserProfile" as well.
I see a test case confirming this save bypass. Wondering how the test passed :)
There was a problem hiding this comment.
I believe "saveUserProfile" should not be called in this case since we are returning stored variation. I wrapped __saveUserProfile call below in if (!shouldIgnoreUPS) {..} statement and added a unit test to incorporate this comment.
yavorona
force-pushed
the
pnguen/ignore-user-profile-service
branch
2 times, most recently
from
af78f6f to
4041f2b
Compare
…gnoreUPS * Update getVariationForFeature method to include options * Fix existing unit test * Add unit test for IGNORE_USER_PROFILE_SERVICE flag in decide options
yavorona
force-pushed
the
pnguen/ignore-user-profile-service
branch
from
4041f2b to
396e0e2
Compare
mjc1283
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Note
This pr is to be finalized once #640 is merged