feat: defaultDecideOptions in SDKOptions #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavorona
reviewed
Feb 2, 2021
| @@ -207,6 +207,8 @@ export interface SDKOptions { | |||
| sdkKey?: string; | |||
| // user profile that contains user information | |||
| userProfileService?: UserProfileService; | |||
| // dafailt options for decide API | |||
| defaultDecideOptions?: OptimizelyDecideOption[] | undefined | |||
There was a problem hiding this comment.
Not sure if specifying undefined as a type is needed in this case as it is an optional parameter. WDYT @mjc1283 ?
There was a problem hiding this comment.
Agree, @yavorona . @ozayr-zaviar please fix.
mjc1283
suggested changes
Feb 2, 2021
| @@ -207,6 +207,8 @@ export interface SDKOptions { | |||
| sdkKey?: string; | |||
| // user profile that contains user information | |||
| userProfileService?: UserProfileService; | |||
| // dafailt options for decide API | |||
| defaultDecideOptions?: OptimizelyDecideOption[] | undefined | |||
There was a problem hiding this comment.
Agree, @yavorona . @ozayr-zaviar please fix.
yavorona
approved these changes
Feb 2, 2021
mjc1283
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
defaultDecideOptionsin SDKOption type added.Test plan
@DEFAULT_DECIDE_OPTIONSshould pass.