Skip to content

fix: Fix type definitions to avoid compiling source files #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 2, 2021

Conversation

yavorona
Copy link
Contributor

@yavorona yavorona commented Mar 1, 2021

Summary

To prevent users from compiling our TS source files, the type definitions file index.d.ts has been updated to exclude imports from our source files (OptimizelyUserContext and OptimizelyDecision).

Test plan

Existing unit tests

Issues

Issue #654

@coveralls
Copy link

coveralls commented Mar 1, 2021

Coverage Status

Coverage remained the same at 96.957% when pulling ed9ffc6 on pnguen/fix-type-definitions into 7969661 on master.

@yavorona yavorona changed the title fix: Fix time definitions to avoid compiling source files fix: Fix type definitions to avoid compiling source files Mar 2, 2021
@yavorona yavorona removed their assignment Mar 2, 2021
Copy link
Contributor

@zashraf1985 zashraf1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yavorona yavorona merged commit 553dd69 into master Mar 2, 2021
@yavorona yavorona deleted the pnguen/fix-type-definitions branch March 2, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants