Skip to content

fix:(event processor): Update ConversionEvent interface #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 14, 2021
Merged

fix:(event processor): Update ConversionEvent interface #681

merged 4 commits into from
Jun 14, 2021

Conversation

yavorona
Copy link
Contributor

@yavorona yavorona commented Jun 9, 2021 •
edited
Loading

Summary

  • Update ConversionEvent interface to allow event id type null and tags type undefined

The "why", or other context.

Test plan

  • Existing unit tests + added new tests

@yavorona yavorona requested a review from a team as a code owner June 9, 2021 23:57
@coveralls
Copy link

coveralls commented Jun 10, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 96.999% when pulling 7216c10 on pnguen/ep-update-conversion-event-interface into e85de4d on master.

@yavorona yavorona removed their assignment Jun 11, 2021
zashraf1985
zashraf1985 approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@zashraf1985 zashraf1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but just curios why is it needed.

@yavorona
Copy link
Contributor Author

Looks good but just curios why is it needed.

This is needed to avoid compiler errors in optimizely-sdk package, where we also allow event id to be null and tags to be undefined when building a conversionEvent obj that is being processed by event processor in our optimizely module.

@yavorona yavorona merged commit 004e22a into master Jun 14, 2021
@yavorona yavorona deleted the pnguen/ep-update-conversion-event-interface branch June 14, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zashraf1985 zashraf1985 zashraf1985 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🤖 8 hrs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yavorona @coveralls @zashraf1985 @optimizely-codereview-bot