Replace bluebird dependency with smaller es6-promise library. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haleybash-optimizely
approved these changes
Sep 21, 2016
mjc1283
added a commit
that referenced
this pull request
Apr 22, 2019
…ntry point (#8) Summary: This adds several small, but required, fixes: - Update README - Rename liveUpdates to autoUpdate - Increase minimum allowed update interval to 1000 ms - Increase default update interval to 5 minutes - Introduce abstract method for subclasses to provide default config. Use this for autoUpdate default true in node, false in browser - Add top-level entry points for node (index.node.ts) and browser (index.browser.ts) - package.json fixes: Fix license, move @types/node to dev dependencies, add build script, add browser/node entry points - Remove unused DatafileManagerConfig interface properties - Add missing license header in some files Test plan: Updated affected unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@haleybash-optimizely @aliabbasrizvi @delikat @vignesh-optimizely @wangjoshuah @jophde
This reduces the size of our minified bundle from 180kb to 113kb.