Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9984] fix: Empty fetched qualified segments validity #916

Merged
merged 2 commits into from
Mar 22, 2024
Merged

[FSSDK-9984] fix: Empty fetched qualified segments validity #916

merged 2 commits into from
Mar 22, 2024

Conversation

mikechu-optimizely
Copy link
Contributor

Summary

  • fetchQualifiedSegments returning and empty array [ ] is valid

Test plan

  • Added test cases

Issues

  • FSSDK-9984

@coveralls
Copy link

Coverage Status

coverage: 90.381% (+0.007%) from 90.374%
when pulling ee06a43 on mike/FSSDK-9984/fix-empty-segments
into 6be2631 on master.

@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review March 21, 2024 19:54
@mikechu-optimizely mikechu-optimizely requested a review from a team as a code owner March 21, 2024 19:54
jaeopt
jaeopt approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely mikechu-optimizely mentioned this pull request Mar 21, 2024
Closed
1 task
raju-opti
raju-opti approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely mikechu-optimizely merged commit a1e6110 into master Mar 22, 2024
20 checks passed
@mikechu-optimizely mikechu-optimizely deleted the mike/FSSDK-9984/fix-empty-segments branch March 22, 2024 09:12
@mikechu-optimizely
Copy link
Contributor Author

Wooops. Empty [ ]s are truthy past @mikechu-optimizely. C'mon man.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@raju-opti raju-opti raju-opti approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikechu-optimizely @coveralls @jaeopt @raju-opti