Skip to content

[FSSDK-10201] queueMicrotask alternative for unsupported platforms #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 6, 2024

Conversation

junaed-optimizely
Copy link
Contributor

@junaed-optimizely junaed-optimizely commented Jun 5, 2024

Summary

JS SDK should fall back to setTimeout when queueMicrotask is unavailable in an embedded environment

Test plan

Unit test has been added for the change

Issues

FSSDK-10201

@coveralls
Copy link

Coverage Status

coverage: 90.3% (-0.008%) from 90.308%
when pulling e3dae0c on junaed/FSSDK-10201
into 851b066 on master.

Copy link

@muzahidul-opti muzahidul-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The changes are well-structured and improve the codebase. However, it would be beneficial to add test cases to ensure the new functionality works as expected.

@coveralls
Copy link

Coverage Status

coverage: 90.311% (+0.003%) from 90.308%
when pulling 4d09d4c on junaed/FSSDK-10201
into 851b066 on master.

@coveralls
Copy link

Coverage Status

coverage: 23.012% (-67.3%) from 90.308%
when pulling 39c8f72 on junaed/FSSDK-10201
into 851b066 on master.

@coveralls
Copy link

Coverage Status

coverage: 90.308%. remained the same
when pulling 17ea6f4 on junaed/FSSDK-10201
into 851b066 on master.

@coveralls
Copy link

Coverage Status

coverage: 90.307% (-0.001%) from 90.308%
when pulling 8002ade on junaed/FSSDK-10201
into 851b066 on master.

@junaed-optimizely junaed-optimizely merged commit c9972e6 into master Jun 6, 2024
15 of 20 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/FSSDK-10201 branch June 6, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants