Skip to content

[FSSDK-10464] update import for uuid #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2024
Merged

[FSSDK-10464] update import for uuid #961

merged 2 commits into from
Nov 18, 2024

Conversation

raju-opti
Copy link
Contributor

@raju-opti raju-opti commented Nov 15, 2024 •
edited
Loading

Summary

  • update the way uuid module is used cause it was causing issues for some clients

Test plan

  • all existing tests should pass

Issues

  • FSSDK-10464

@raju-opti raju-opti requested a review from a team as a code owner November 15, 2024 18:01
@coveralls
Copy link

coveralls commented Nov 15, 2024 •
edited
Loading

Coverage Status

coverage: 96.982%. remained the same
when pulling 9fcee71 on raju/uuid-v4
into 16cda94 on 4.x.x.

jaeopt
jaeopt approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raju-opti raju-opti merged commit bfcdc49 into 4.x.x Nov 18, 2024
28 checks passed
@raju-opti raju-opti deleted the raju/uuid-v4 branch November 18, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

@junaed-optimizely junaed-optimizely Awaiting requested review from junaed-optimizely

Assignees

@raju-opti raju-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raju-opti @coveralls @jaeopt @mikechu-optimizely