Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-11098] using readyPromise instead of onReady #995

Merged
merged 1 commit into from
Jan 29, 2025
Merged

[FSSDK-11098] using readyPromise instead of onReady #995

merged 1 commit into from
Jan 29, 2025
+8 −2

Conversation

junaed-optimizely
Copy link
Contributor

raju-opti
raju-opti approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

coverage: 90.366% (+0.06%) from 90.309%
when pulling 274bb2d on junaed/fssdk-11098-issue-with-akamai-edge-worker
into 8f572ff on 5.x.x.

@junaed-optimizely junaed-optimizely merged commit 617fa35 into 5.x.x Jan 29, 2025
19 of 20 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-11098-issue-with-akamai-edge-worker branch January 29, 2025 13:54
@junaed-optimizely junaed-optimizely mentioned this pull request Jan 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raju-opti raju-opti raju-opti approved these changes

Assignees

@junaed-optimizely junaed-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junaed-optimizely @coveralls @raju-opti