simoneDev Bug fix #124
Merged
simoneDev Bug fix #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@docsimon thanks! Can you fill out or CLA so we can accept your fix? https://github.com/optimizely/objective-c-sdk/blob/master/CONTRIBUTING.md |
|
Yep good catch @docsimon! This will go out in our next release. ;) |
|
Hi,
I provided to fill out the CLA
Cheers
Simone
… On 20 Apr 2017, at 19:51, Joshua Wang ***@***.***> wrote:
@docsimon <https://github.com/docsimon> thanks! Can you fill out or CLA so we can accept your fix? https://github.com/optimizely/objective-c-sdk/blob/master/CONTRIBUTING.md <https://github.com/optimizely/objective-c-sdk/blob/master/CONTRIBUTING.md>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#124 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASS89bp95wGbyzWRoYQ76dQzrAIj1NABks5rx6lDgaJpZM4M-e6->.
|
alda-optimizely
added a commit
that referenced
this pull request
May 2, 2017
* Alda/universal framework (#122) * First pass at making a universal framework. * Fixed pods issue. * Working iOS universal framework. * Alphabetized header file for the core. * Updated pods for the iOS and tvOS universal targets. * Working iOS and tvOS universal framework builds. * Files left out from previous commit. * OptimizelySDK.xcodeproj/xcshareddata/ * Removed version control warnings from xcode. * Added submodules for json model and fmdb for the universal framework. * Fixed some scheme and target settings. * Had to add the other json model files to the source compilation. * Working iOS script. * Working apple tv universal framework script. * Changed how some header files are imported. * Moved folder ordering in xcode. * Added bitcode. * Changed framework names. * Changed the folder and project names. * Updated submodules. * Fixed broken file pointers in the workspace. * Fixe submodules and file pointers. * Cleaned up some project settings. * Fixed broken tests -- bad imports as some file names have changed. * Changed scheme names to distinguish the universal frameworks. * Added tests to universal framework to fix the jenkins build. * Removed sample code in demo app left by accident. * Changed the imports to quotes insted of brackets to make the imports for the universal framework consistent. * Cleaned up the header search paths. * Uncommented client version number. * Removed xcode meta data and added the file to the gitignore file. * Mistakenly removed end for audience protocol. * Fixed some nits. * Fixed pointers to the files to be relative to the project. * Moved the third-party library headers out of the project level since it wasn't accessble by the app. * Changed the script to output the universal framework to another folder. * Had to move the third-party libraries to public. * Changed some third-party file references from absolute path to relative to group. * Changed Cocoapods to 1.2.0 (non beta) version and did a pod update. * Added the generated universal framework in the repo so users don't have to build it themselves. * Changed the ssh reference to https for the git submodules since travis couldn't pull it. * Check universal framework version number. * Explicityly specify the architectures in the build script. * Updated the release script to build the universal frameworks. * Updated the generated universal frameworks. * Updated instructions on manual installation * Fixed some nits in README. * Used relative reference for the iOS and tvOS frameworks. * Zip the univeral frameworks for easier downloads. * Fixed the cases for the device architectures. * Changed the zipped frameworks and script so that it doesn't zip unwanted directoectories. * Bad zipped framework upload from before. * Removed and added the Shared framework in event dispatcher to get rid of the ReferenceProxy reference in the project file. * Fixed notes on installing the universal frameworks. * Added more notes to the README. * Fixed a typo. * Fixed more README. * Fixed some README wording. * Forgot to link the Shared library when I removed and added it back. * Add support for event tags (#123) * Adds support for event tags * Update existing tests * Add event builder tests * Clean up leftover testing code * Respond to Alda's CR feedback * Add requested tests * Fix broken test * Smarter check of revenue value validity * Make event tag validity check more readable * Refactor buildDecisionEventTicket to be consistent with buildEventTicket * Respond to Alda's CR feedback * Update README.md Fixed grammar nit. * Bug fix for parsing multiple conditions (#124) @SimoneDev fixed a bug in our parsing of base conditions. * change the way not conditions are parsed in audiences (#125) * change the way not conditions are parsed in audiences * add complex audience test * Alda/negative timestamp fix (#126) * Changed the event ticket models to support long long so that 32-bit architectures will use the 64-bit integer value. These data models are not being used at the moment though -- this is to prevent future error. * Add a better check for the event timestamp. * Updated the local travis scrip to reflect what's actually being called in travis. * Updated the CHANGELOG for 1.1.0 release. (#127) * Updated the CHANGELOG for 1.1.0 release. * Updated CHANGELOG. * Added one more bug fix that is going to be included in the release. * Fixed grammar nits. * Fixed more nits. * Alda/event tags fix (#129) * Made how we set the boolean values in the events more consistent -- they should be set to @YES/@no or @true/@false; otherwise, they won't be parsed properly in JSON. * Cast the revenue value to an integer if the user inputs a double or float. * Set shouldIndex for events to falseto be consistent with the rest of the SDKS. Backend says this value should not matter as it was for druid purposes. * Check more types in revenue. Also fixed event builder tests. * Fixed timestamp for events -- this value should be a long long, not double. Also added some useful code comments. * Fixed test and indentation. * Bumped iOS support to 10.2. * Removed code comment from demo app, which was left there by accident. * Bumped the release date in the CHANGELOG. * Updated the Contribution document to reflect our new way of merging external changes. * Bumped the date for release on the Changelog. * Bumped version numbers of all modules. * Bumped version for new release. * Built the universal frameworks. * Bumped CHANGELOG release date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed jsonArray[1] to jsonArray[i] inside the for loop of the function
+ (NSArray *)deserializeJSONArray:(NSArray *)jsonArray
in the OPTLYCondition.m file