fix(audienceeval): Multiple fixes #355
Conversation
yasirfolio3
commented
Jan 10, 2019
•
yasirfolio3
commented
- For JSON parsing of Leaf condition, mark property 'type' as optional. Return null if leaf condition is evaluated with property 'type' null.
- Fixed Audience Conditions Deserialization for empty array.
- Fixed Audience Conditions Deserialization for a condition when leaf contains both audience id and a conditions array.
- Fixed cases where Audience should be evaluated as null and was instead returning false.
- Implemented test-cases for Audience Evaluation to fix issues detected on full-stack.
1 similar comment
…le audience Ids and no Evaluation operator.
…here leaf node can contain further conditions array. 2. Fixed cases where Audience should be evaluated as null and is transformed to false in the final state. 3. Implemented test-cases for Audience Evaluation to fix issues detected on full-stack.
yasirfolio3
changed the title
msohailhussain
changed the title
|
@thomaszurkan-optimizely we added some more fixes. |
|
Test-cases added for null or empty user attributes in Not condition, please review. |
| NSArray *notConditionArray = @[@"not", @"3988293898"]; | ||
| NSArray *conditions = [OPTLYCondition deserializeAudienceConditionsJSONArray:notConditionArray]; | ||
| OPTLYNotCondition *notCondition = (OPTLYNotCondition *)[conditions firstObject]; | ||
| XCTAssertNil([notCondition evaluateConditionsWithAttributes:userAttributes projectConfig:self.optimizelyTypedAudience.config]); |
There was a problem hiding this comment.
How does this evaluate if there are no attributes (passing in nil for attributes)? I called activate with nil attributes on a experiment with a audience combination negated. So, match [not "brower_type" has substring "chrome"] and it passed. But, that was before these changes.
There was a problem hiding this comment.
The reason for this was that Evaluators for Experiment as well as Audiences were returning false if evaluation was null, which was then converted to true by the 'NOT' operator. Now all evaluators can return null aswell, and so when not operator recieves null as evaluation result, it returns null too. See change:
https://github.com/optimizely/objective-c-sdk/pull/355/files#diff-14f1494cb8efebbed033865e5c25e335R58
https://github.com/optimizely/objective-c-sdk/pull/355/files#diff-8749178f3084f0c32b0ea09b5615e095R32
https://github.com/optimizely/objective-c-sdk/pull/355/files#diff-e39e60da2e49e74d868de2fc69c31377R44
I have updated the testcases for activate call with not conditions aswell, please review.
…nil or empty attributes updated.
