Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(emptybucketingid): Empty bucketing id should be acceptable. #367

Merged
merged 3 commits into from
Jan 30, 2019
Merged

fix(emptybucketingid): Empty bucketing id should be acceptable. #367

merged 3 commits into from
Jan 30, 2019

Conversation

msohailhussain
Copy link
Contributor

Summary

Empty bucketing ID should be acceptable for all getVariation, getFeatureForRollout, getVariationForFeatureGroup

Test plan

Unit test added.

yasirfolio3
yasirfolio3 approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Jan 29, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 97.953% when pulling d2de3bf on sohail/emptybucketingid into c69f2b5 on master.

@msohailhussain
Copy link
Contributor Author

build

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mikeproeng37
Copy link
Contributor

I am running compat suite tests on Travis here: https://travis-ci.com/optimizely/fullstack-sdk-compatibility-suite/builds/99034529

@mikeproeng37
Copy link
Contributor

Ok this passed!

@mikeproeng37 mikeproeng37 merged commit 3007efc into master Jan 30, 2019
@msohailhussain msohailhussain deleted the sohail/emptybucketingid branch January 31, 2019 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

@yasirfolio3 yasirfolio3 yasirfolio3 approved these changes

@jaeopt jaeopt Awaiting requested review from jaeopt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msohailhussain @coveralls @mikeproeng37 @thomaszurkan-optimizely @yasirfolio3