Skip to content

fix(Config-update): Fix issues with config-update listener. #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2022
Merged

fix(Config-update): Fix issues with config-update listener. #42

merged 2 commits into from
Nov 1, 2022

Conversation

yasirfolio3
Copy link
Contributor

Summary

  • Fixed an issue which was causing configUpdate listener to not trigger.

Test plan

  • All unit and integration tests should pass.

msohailhussain
msohailhussain approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msohailhussain msohailhussain merged commit f0899c8 into master Nov 1, 2022
@msohailhussain msohailhussain deleted the yasir/fixes-bugbash branch November 1, 2022 05:05
@yasirfolio3 yasirfolio3 mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yasirfolio3 @msohailhussain @NomanShoaib