Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): Feature variable APIs return default variable value when featureEnabled property is false. #171

Merged
merged 3 commits into from
Apr 2, 2019
Merged

feat(api): Feature variable APIs return default variable value when featureEnabled property is false. #171

merged 3 commits into from
Apr 2, 2019

Conversation

rashidsp
Copy link
Contributor

Summary

  • Feature variable APIs now return default variable value when featureEnabled property is false.

Test plan

  • Added unit tests.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0009%) to 99.708% when pulling f22cc9d on oakbani/return-default-value-when-featureenabled-false into f772ecc on master.

@coveralls
Copy link

coveralls commented Mar 28, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.0008%) to 99.709% when pulling 3aedc69 on oakbani/return-default-value-when-featureenabled-false into 92490ee on master.

@rashidsp rashidsp requested a review from a team March 28, 2019 16:47
aliabbasrizvi
aliabbasrizvi approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

aliabbasrizvi
aliabbasrizvi approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@aliabbasrizvi aliabbasrizvi merged commit 1f34b2a into master Apr 2, 2019
@aliabbasrizvi aliabbasrizvi deleted the oakbani/return-default-value-when-featureenabled-false branch April 2, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rashidsp @coveralls @aliabbasrizvi @oakbani