Skip to content

fix: change datafile accessor feature to return a string representation of datafile #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 24, 2020
Merged

fix: change datafile accessor feature to return a string representation of datafile #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c99ebe
fix: change datafile accessor methods to return a JSON representation…
pthompson127 Jul 9, 2020
97367fa
fix: change datafile accessor methods to return string instead of byt…
pthompson127 Jul 9, 2020
7b01de7
test: update optimizely config datafile var name in test
pthompson127 Jul 9, 2020
cc57cd4
refactor: add string encoding
pthompson127 Jul 9, 2020
6357c04
Setting as unicode
aliabbasrizvi Jul 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions optimizely/optimizely_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ def __init__(self, revision, experiments_map, features_map, datafile=None):
self.revision = revision
self.experiments_map = experiments_map
self.features_map = features_map
self.datafile = datafile
self._datafile = datafile

def get_datafile(self):
""" Get the datafile associated with OptimizelyConfig.

Returns:
A JSON string representation of the environment's datafile.
"""
return self.datafile
return self._datafile


class OptimizelyExperiment(object):
Expand Down
2 changes: 1 addition & 1 deletion optimizely/project_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def __init__(self, datafile, logger, error_handler):
"""

config = json.loads(datafile)
self._datafile = datafile
self._datafile = u'{}'.format(datafile)
self.logger = logger
self.error_handler = error_handler
self.version = config.get('version')
Expand Down
2 changes: 1 addition & 1 deletion tests/test_optimizely_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ def setUp(self):
}
},
'revision': '1',
'datafile': json.dumps(self.config_dict_with_features)
'_datafile': json.dumps(self.config_dict_with_features)
}

self.actual_config = self.opt_config_service.get_config()
Expand Down