Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: BatchEventProcessor as Default Event Processor #378

Merged
merged 8 commits into from
Jun 28, 2022
Merged

feat: BatchEventProcessor as Default Event Processor #378

merged 8 commits into from
Jun 28, 2022

Conversation

ozayr-zaviar
Copy link
Contributor

Summary

  • ForwardingEventProcessor sends calls in a synchronous manner so to reduce the time it is replaced with BatchEventProcessor which sends calls in an asynchronous manner.

Test plan

  • All unit tests and FSC tests should pass.

@ozayr-zaviar ozayr-zaviar removed their assignment Feb 18, 2022
msohailhussain
msohailhussain approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrewleap-optimizely andrewleap-optimizely marked this pull request as ready for review June 15, 2022 21:13
@andrewleap-optimizely andrewleap-optimizely requested a review from a team as a code owner June 15, 2022 21:13
@andrewleap-optimizely
Copy link
Contributor

@msohailhussain made some small changes to fix the broken tests and make the api more intuitive.

andrewleap-optimizely
andrewleap-optimizely approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@andrewleap-optimizely andrewleap-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

msohailhussain
msohailhussain approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msohailhussain msohailhussain merged commit 6b590eb into master Jun 28, 2022
@msohailhussain msohailhussain deleted the uzair/default_batch_event_processor branch June 28, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewleap-optimizely andrewleap-optimizely andrewleap-optimizely approved these changes

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees
No one assigned
Labels
🤖 24 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ozayr-zaviar @andrewleap-optimizely @msohailhussain @optimizely-codereview-bot