chore: removed travis yml and added git action support #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msohailhussain
approved these changes
Apr 13, 2022
Contributor
msohailhussain
left a comment
msohailhussain
left a comment
There was a problem hiding this comment.
please address comments and lgtm
| test: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 |
| run: | | ||
| flake8 | ||
| # stop the build if there are Python syntax errors or undefined names | ||
| flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics |
Contributor
There was a problem hiding this comment.
i don't see this line in travis?
| # stop the build if there are Python syntax errors or undefined names | ||
| flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics | ||
| # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide | ||
| flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics |
Contributor
Author
There was a problem hiding this comment.
Comments are written above for clarification. These lines were generated automatically so I didn't removed it as it seemed useful
| if: ${{ github.event_name == 'pull_request' }} | ||
| run: | | ||
| echo "SDK_BRANCH=${{ github.head_ref }}" >> $GITHUB_ENV | ||
| echo "TRAVIS_BRANCH=${{ github.head_ref }}" >> $GITHUB_ENV |
revert to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
All tests should pass
https://github.com/optimizely/python-sdk/runs/6184738570?check_suite_focus=true