fix: handle datafile provided as bytes #384
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
PollingConfigManager
provides the datafile as bytes.Test plan
Issues
Currently if the datafile is provided as bytes, including using the default
PollingConfigManager
, it is converted to str incorrectly, resulting in an invalid JSON string being returned fromProjectConfig.to_datafile
andOptimizelyConfig.get_datafile
.Steps to replicate: