feat(ForcedDecisions): Add forced-decisions APIs to ReactSDKClient and update useDecision hook to reflect changes #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zashraf1985
suggested changes
Nov 15, 2021
cristianparcu-epi
force-pushed
the
cris/forced-decisions
branch
from
6a39b87 to
fbe891d
Compare
zashraf1985
suggested changes
Nov 24, 2021
Comment on lines
+354
to
+356
| const getCurrentDecision: () => { decision: OptimizelyDecision } = () => ({ | ||
| decision: optimizely.decide(flagKey, options.decideOptions, overrides.overrideUserId, overrideAttrs), | ||
| }); |
There was a problem hiding this comment.
This was probably done to make sure decide is only called if any of the inputs that it depends on, change. Removing this from a useCallback hook might result in it being called multiple times on same inputs
src/hooks.ts
Outdated
Comment on lines
431
to
438
| useEffect(() => { | ||
| if (lastUserUpdate) { | ||
| setState(prevState => ({ | ||
| ...prevState, | ||
| ...getCurrentDecision(), | ||
| })); | ||
| } | ||
| }, [lastUserUpdate]); |
There was a problem hiding this comment.
This whole implementation for forced decision looks great. Can you add unit tests to cover all the scenarios
| * @param {optimizely.OptimizelyForcedDecision} forcedDecision | ||
| * @memberof OptimizelyReactSDKClient | ||
| */ | ||
| public setForcedDecision( |
There was a problem hiding this comment.
Can you add unit tests for this?
cristianparcu-epi
force-pushed
the
cris/forced-decisions
branch
from
fbe891d to
713ae00
Compare
cristianparcu-epi
force-pushed
the
cris/forced-decisions
branch
from
713ae00 to
e50aa5b
Compare
Sherry was working from his fork due to access issues. Now merging it back to the same branch in base repo.
zashraf1985
changed the title
zashraf1985
changed the title
zashraf1985
changed the title
zashraf1985
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a set of new APIs for forced-decisions to ReactSDKClient.
Also updated
useDecisionhook to autoupdate and reflect changes when forced decisions are set and removed.Test Plan