refactor: Return ReactSDKClient interface from createInstance instead of implementation class
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zashraf1985
approved these changes
Feb 2, 2022
Comment on lines
+21
to
+24
| interface MockedReactSDKClient extends ReactSDKClient { | ||
| client: optimizely.Client; | ||
| initialConfig: optimizely.Config; | ||
| } |
There was a problem hiding this comment.
This is clever. Great Job!
…that this type is extended from.
zashraf1985
changed the title
createInstanceReactSDKClient interface from createInstance instead of implementation class
zashraf1985
changed the title
ReactSDKClient interface from createInstance instead of implementation classReactSDKClient interface from createInstance instead of implementation class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Return type of createInstance was OptimizelyReactSDKClient which is the implementation class. Changed it to the ReactSDKClient interface instead.
Test Plan
Issues
#49