Fix: Upgrade to react 18 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zashraf1985
suggested changes
May 17, 2022
| @@ -45,5 +45,5 @@ jobs: | |||
| TRAVIS_COM_TOKEN: ${{ secrets.TRAVIS_COM_TOKEN }} | |||
| EVENT_MESSAGE: ${{ github.event.message }} | |||
| HOME: 'home/runner' | |||
| run: | | |||
There was a problem hiding this comment.
This looks like an unnecessary change. can you re add the space here so that it does not appear in the PR diff
src/hooks.spec.tsx
Outdated
| <OptimizelyProvider optimizely={optimizelyMock}> | ||
| <MyExperimentComponent options={{ timeout: mockDelay }} /> | ||
| </OptimizelyProvider> | ||
| ); | ||
| expect(component.text()).toBe('null|false|false'); // initial render | ||
| await waitFor(() => expect(screen.getByTestId('result')).toHaveTextContent('null|false|false')); |
There was a problem hiding this comment.
Can you add the // initial render comment here again
|
@opti-jnguyen Can you take a look when you get some time. |
zashraf1985
approved these changes
May 19, 2022
opti-jnguyen
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
enzymewithreact testing libraryto make unit tests work with React 18.Test Plan