EventBuilder uses the same logger as Project

[bcobb]

👋 This recently caused a bit of noise for us 😅 after upgrading our SDK. It looks like Optimizely::Project is intended to work without a custom logger, but tracking events with tags started raising NoMethodError:

$GEM_HOME/optimizely-sdk-2.1.0/lib/optimizely/helpers/event_tag_utils.rb:52:in `get_revenue_value': undefined method `log' for nil:NilClass (NoMethodError)
    from $GEM_HOME/optimizely-sdk-2.1.0/lib/optimizely/event_builder.rb:220:in `block in get_conversion_params'
    from $GEM_HOME/optimizely-sdk-2.1.0/lib/optimizely/event_builder.rb:202:in `each'
    from $GEM_HOME/optimizely-sdk-2.1.0/lib/optimizely/event_builder.rb:202:in `get_conversion_params'
    from $GEM_HOME/optimizely-sdk-2.1.0/lib/optimizely/event_builder.rb:155:in `create_conversion_event'
    from $GEM_HOME/optimizely-sdk-2.1.0/lib/optimizely.rb:230:in `track'

---

• Previously, EventBuilder was instantiated by Project with the
  value of the logger local. However, when Project was not
  instantiated with a custom logger, EventBuilder would be
  instantiated with nil logger, which would cause track to raise a
  NoMethodError when called with tags.
• This commit changes the Project constructor to pass the @logger
  instance variable to EventBuilder, so that they are using the same
  logger, custom or otherwise.
• The added spec fails prior to the constructor change

[optibot]

Can one of the admins verify this patch?

[optibot]

Can one of the admins verify this patch?

[aliabbasrizvi]

@bcobb thank you for sending this in and taking care of signing the CLA. Will take a look at this and get back to you.

[coveralls]

Coverage remained the same at 100.0% when pulling aeea680 on harrystech:fix-event-builder-logger into ffb910c on optimizely:master.

[mikeproeng37]

lgtm

[mikeproeng37]

PR fails tests, but after merging master into the locally checked out branch, tests were passing again as evidenced in #126. Going to merge in.