feat(api): Feature variable APIs return default variable value when featureEnabled property is false. #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eatureEnabled property is false.
aliabbasrizvi
suggested changes
Mar 26, 2019
Contributor
aliabbasrizvi
left a comment
aliabbasrizvi
left a comment
There was a problem hiding this comment.
Please correct the log message. Otherwise it looks good.
lib/optimizely.rb
Outdated
| variation_variable_usages = @config.variation_id_to_variable_usage_map[variation['id']] | ||
| variable_id = variable['id'] | ||
| if variation_variable_usages&.key?(variable_id) | ||
| if variation['featureEnabled'] && variation_variable_usages&.key?(variable_id) |
Contributor
There was a problem hiding this comment.
I think the log message in the else clause is incorrect for this new scenario. It should be the log message in the else clause for decision (above). Please update accordingly.
aliabbasrizvi
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan