Skip to content

Conversation

@rashidsp
Copy link
Contributor

@rashidsp rashidsp commented Aug 20, 2019

Summary

  • Introduced LogEvent notification in notification_center.rb.
  • Integrated it in batch_event_dispatcher.rb and forwarding_event_processor.rb.
  • Added notification_count in notification_center.rb and integrated into Optimizely for notification types ACTIVATE and TRACK.

Test plan

  • Added unit tests for LogEvent in notification_center_spec.rb, batch_event_dispatcher_spec.rb and forwarding_event_processor_spec.rb.
  • Updated Optimizely's unit tests for LogEvent and notification_count.

@rashidsp rashidsp added the WIP Work in progress label Aug 20, 2019
@rashidsp rashidsp requested a review from a team as a code owner August 20, 2019 07:45
@coveralls
Copy link

coveralls commented Aug 20, 2019

Coverage Status

Coverage increased (+0.02%) to 99.442% when pulling ecf2d6e on rashid/Batch-EP-logEvent into 2df63ad on master.

@rashidsp rashidsp removed the WIP Work in progress label Aug 28, 2019
@rashidsp rashidsp changed the title feat(notification-center): Add LogEvent notification- WIP feat(notification-center): Add LogEvent notification Aug 28, 2019
@rashidsp rashidsp changed the base branch from rashid/optly-EP-integration to master August 29, 2019 09:52
@msohailhussain
Copy link
Contributor

@rashidsp there are so many commits in this PR which are irrelevant, can you please create a new PR with only single commit?

@rashidsp
Copy link
Contributor Author

Created clean PR: #197
Therefore closing it.

@rashidsp rashidsp closed this Aug 29, 2019
@rashidsp rashidsp deleted the rashid/Batch-EP-logEvent branch August 29, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants