Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-10771] Implement UPS request batching for decideForKeys #559

Merged
merged 14 commits into from
Nov 8, 2024
Merged

[FSSDK-10771] Implement UPS request batching for decideForKeys #559

merged 14 commits into from
Nov 8, 2024

Conversation

muzahidul-opti
Copy link
Contributor

@muzahidul-opti muzahidul-opti commented Oct 23, 2024 •
edited
Loading

Summary

  • Currently, decideForKeys loops over the list of flags and calls decide for each, which in turn calls ups. So for decideForKeys, there is two calls per flag to UPS. This PR batches UPS calls when using decideForKeys.

Test plan

Issues

@muzahidul-opti muzahidul-opti changed the title Muzahid/ups draft [FSSDK-10771] Implement UPS request batching for decideForKeys Oct 23, 2024
@muzahidul-opti muzahidul-opti marked this pull request as ready for review October 23, 2024 18:17
@muzahidul-opti muzahidul-opti requested a review from a team as a code owner October 23, 2024 18:17
@muzahidul-opti muzahidul-opti requested a review from jaeopt October 23, 2024 18:18
jaeopt
jaeopt requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One change required - UPS should not be used for rollout decisions.

@muzahidul-opti muzahidul-opti requested a review from jaeopt October 30, 2024 17:03
raju-opti
raju-opti previously approved these changes Nov 7, 2024
View reviewed changes
Copy link

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have one question

jaeopt
jaeopt approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muzahidul-opti muzahidul-opti merged commit 548f371 into master Nov 8, 2024
12 checks passed
@muzahidul-opti muzahidul-opti deleted the muzahid/ups-draft branch November 8, 2024 12:06
muzahidul-opti added a commit that referenced this pull request Nov 8, 2024
@muzahidul-opti
Merge branch 'master' into muzahid/vuid-optln
7e49835 
* master:
  [FSSDK-10771] Implement UPS request batching for decideForKeys (#559)

# Conflicts:
#	OptimizelySwiftSDK.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@raju-opti raju-opti raju-opti left review comments

Assignees

@muzahidul-opti muzahidul-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muzahidul-opti @jaeopt @raju-opti