Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-11036] fix: event tags support nested objects #570

Merged
merged 16 commits into from
Feb 4, 2025

Conversation

muzahidul-opti
Copy link
Contributor

@muzahidul-opti muzahidul-opti commented Jan 20, 2025

Summary

  • Event tags support nested objects
  • Fix the workflow simulator version

Test plan

  • All previous test cases should be passed

Issues

@muzahidul-opti muzahidul-opti marked this pull request as ready for review January 22, 2025 18:25
@muzahidul-opti muzahidul-opti requested a review from a team as a code owner January 22, 2025 18:25
@muzahidul-opti muzahidul-opti requested a review from jaeopt January 22, 2025 18:26
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple of small changes.

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muzahidul-opti muzahidul-opti merged commit a5cdf42 into master Feb 4, 2025
12 checks passed
@muzahidul-opti muzahidul-opti deleted the muzahid/fix-nested-event-tag branch February 4, 2025 15:36
muzahidul-opti added a commit that referenced this pull request Apr 7, 2025
* master:
  [FSSDK-11371] parsing holdout section from the datafile (#577)
  [FSSDK-11111] chore: update cocoapods version (#576)
  [FSSDK-11102] chore: replace travis-ci-tools repository (#571)
  ci(git-action): auto release prep for 5.1.0 (#575)
  [FSSDK-11111] chore: prepare release 5.1.0 (#574)
  [FSSDK-11036] chore: revert workflow branch to master (#572)
  [FSSDK-11036] fix: event tags support nested objects (#570)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants