[FSSDK-11372] assign holdoutIds to feature flags #578

muzahidul-opti · 2025-03-24T17:19:32Z

Summary

Update the flag's dependent holdoutIds

Test plan

New test cases added

Issues

FSSDK-11372

* master: [FSSDK-11371] parsing holdout section from the datafile (#577) # Conflicts: # Sources/Data Model/ExperimentCore.swift # Sources/Data Model/Holdout.swift

jaeopt

Looks good! Let's discuss options.

Sources/Data Model/FeatureFlag.swift

Sources/Data Model/Project.swift

Sources/Data Model/ProjectConfig.swift

Tests/OptimizelyTests-DataModel/ProjectConfigTests.swift

Sources/Data Model/ProjectConfig.swift

jaeopt

Looks good. We need to add order enforcement as discussed.

Sources/Data Model/FeatureFlag.swift

Sources/Data Model/ProjectConfig.swift

Sources/Data Model/HoldoutConfig.swift

jaeopt

I like the change. It looks like we need to fix ordering.

Sources/Data Model/HoldoutConfig.swift

muzahidul-opti · 2025-04-16T12:17:42Z

I like the change. It looks like we need to fix ordering.
done

jaeopt

Changes looks good! A few more clean up tips.

Sources/Data Model/HoldoutConfig.swift

Sources/Utils/LogMessage.swift

Tests/OptimizelyTests-DataModel/HoldoutConfigTests.swift

Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>

jaeopt

Looks great!

muzahidul-opti and others added 4 commits March 20, 2025 23:02

wip: Holdout Model created

f5e60a7

wip: add holdout model test cases

38386cd

Merge branch 'master' into muzahid/holdout-FSSDK-11371

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

a732fdb

wip: assging holdoutids to feature flags

99eea3d

optimizely-codereview-bot assigned muzahidul-opti Mar 24, 2025

muzahidul-opti added 9 commits March 24, 2025 23:59

wip: included and excluded flags updated to required

326adce

wip: move OptimizelyExperiment compliance to OptmizelyConfig file

d1cc64d

Merge branch 'muzahid/holdout-FSSDK-11371' into muzahid/FSSDK-11372

247d0eb

wip: fix uint test

01f3cd7

Merge branch 'master' into muzahid/FSSDK-11372

5404d97

* master: [FSSDK-11371] parsing holdout section from the datafile (#577) # Conflicts: # Sources/Data Model/ExperimentCore.swift # Sources/Data Model/Holdout.swift

wip: make holdouts array empty if no key presented

3560de9

wip: add id and key to experiement core

51ba12a

wip: clean up

2c29e82

wip: clean up

16920c7

muzahidul-opti marked this pull request as ready for review April 8, 2025 15:57

muzahidul-opti changed the title ~~[FSSDK-11372] assign holdouts to feature flags~~ [FSSDK-11372] assign holdoutIds to feature flags Apr 8, 2025

muzahidul-opti requested a review from jaeopt April 8, 2025 16:05

clean up

7bad66d

jaeopt requested changes Apr 8, 2025

View reviewed changes

muzahidul-opti added 3 commits April 9, 2025 16:15

wip: address review request

b337b35

wip: Update holdout sample data

c694a57

wip: update flag to holdout mapping approach

fd6535a

muzahidul-opti commented Apr 9, 2025

View reviewed changes

Sources/Data Model/ProjectConfig.swift Outdated Show resolved Hide resolved

muzahidul-opti requested a review from jaeopt April 9, 2025 18:24

jaeopt requested changes Apr 10, 2025

View reviewed changes

Sources/Data Model/FeatureFlag.swift Show resolved Hide resolved

Sources/Data Model/ProjectConfig.swift Outdated Show resolved Hide resolved

wip: holdout config struct added

987ff6c

muzahidul-opti commented Apr 15, 2025

View reviewed changes

Sources/Data Model/HoldoutConfig.swift Outdated Show resolved Hide resolved

wip: unit tests updated

528aa0d

muzahidul-opti requested a review from jaeopt April 15, 2025 14:53

jaeopt requested changes Apr 15, 2025

View reviewed changes

muzahidul-opti added 4 commits April 15, 2025 22:14

wip: HoldoutConfig test cases added

c868c29

wip: fix holdout config tests

e876960

clean up: fix test cases

9e1669c

cleanup: add unit test cases

f310734

muzahidul-opti closed this Apr 16, 2025

muzahidul-opti reopened this Apr 16, 2025

muzahidul-opti requested a review from jaeopt April 16, 2025 12:18

jaeopt requested changes Apr 17, 2025

View reviewed changes

muzahidul-opti and others added 2 commits April 17, 2025 23:37

Update Sources/Data Model/HoldoutConfig.swift

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

0ce7aa3

Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>

cleanup: address review changes

05ed9f0

muzahidul-opti requested a review from jaeopt April 18, 2025 15:17

jaeopt approved these changes Apr 18, 2025

View reviewed changes

muzahidul-opti closed this Apr 21, 2025

muzahidul-opti reopened this Apr 21, 2025

muzahidul-opti merged commit 7c4fee7 into master Apr 21, 2025
19 of 22 checks passed

muzahidul-opti deleted the muzahid/FSSDK-11372 branch April 21, 2025 13:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FSSDK-11372] assign holdoutIds to feature flags #578

[FSSDK-11372] assign holdoutIds to feature flags #578

muzahidul-opti commented Mar 24, 2025 •

edited

Loading

jaeopt left a comment

jaeopt left a comment

jaeopt left a comment

muzahidul-opti commented Apr 16, 2025

jaeopt left a comment

jaeopt left a comment

[FSSDK-11372] assign holdoutIds to feature flags #578

[FSSDK-11372] assign holdoutIds to feature flags #578

Conversation

muzahidul-opti commented Mar 24, 2025 • edited Loading

Summary

Test plan

Issues

jaeopt left a comment

Choose a reason for hiding this comment

jaeopt left a comment

Choose a reason for hiding this comment

jaeopt left a comment

Choose a reason for hiding this comment

muzahidul-opti commented Apr 16, 2025

jaeopt left a comment

Choose a reason for hiding this comment

jaeopt left a comment

Choose a reason for hiding this comment

muzahidul-opti commented Mar 24, 2025 •

edited

Loading