Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused file optuna_multi_objective.py #17

Merged
merged 4 commits into from
Apr 8, 2022

Conversation

sile
Copy link
Member

@sile sile commented Apr 7, 2022

This PR removes kurobako/solver/optuna_multi_objective.py as it depends on the deprecated Optuna's multi-objective feature and is not used from anywhere now (as far as I know).
Besides, this PR fixes CI failures on the master branch.

@sile sile force-pushed the remove-unused-file branch 3 times, most recently from 6ac7042 to 002e8f3 Compare April 7, 2022 11:19
@sile sile force-pushed the remove-unused-file branch from ed91e6c to 2cbe22f Compare April 7, 2022 11:23
@contramundum53
Copy link
Member

LGTM!

Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid. LGTM.

@HideakiImamura HideakiImamura merged commit 7fe8f5c into master Apr 8, 2022
@sile sile deleted the remove-unused-file branch April 8, 2022 08:53
@sile
Copy link
Member Author

sile commented Apr 8, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants