Fix bugs in kurobako/solver/optuna.py #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himkt
reviewed
Apr 12, 2022
kurobako/solver/optuna.py
Outdated
| @@ -11,7 +11,7 @@ | |||
| from kurobako import problem | |||
| from kurobako import solver | |||
|
|
|||
| _optuna_logger = optuna.logging.get_logger(__name__) | |||
| _optuna_logger = optuna.logging.get_logger("optuna.study.study") | |||
sile
reviewed
Apr 12, 2022
kurobako/solver/optuna.py
Outdated
Comment on lines
18
to
20
| _optuna_logger.setLevel(optuna.logging.INFO) | ||
| console = logging.StreamHandler() | ||
| _optuna_logger.addHandler(console) |
There was a problem hiding this comment.
Could you explain the necessity of this change?
There was a problem hiding this comment.
In my understanding, handlers and log levels are usually set in the user code, not library code.
I don't think it is a good practice to show log messages.
|
I privately discuss above with @contramundum53 and @sile. As a result, we have decided to generate a log in our own format for the completed trials in this PR. The reason are
|
|
We reverted changes about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several bugs were present in
kurobako/solver/optuna.pythat resulted in errors when used with nontrivial pruners.trial.last_stepis undefined whentrialis not aFrozenTrial.self._study._log_completed_trialrequries aFrozenTrial, but aTrialis passedThese bugs are fixed in this PR.