Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "sile" in the doc with "optuna". #39

Merged
merged 3 commits into from
Jun 24, 2021
Merged

Replace "sile" in the doc with "optuna". #39

merged 3 commits into from
Jun 24, 2021

Conversation

sile
Copy link
Member

@sile sile commented Jun 24, 2021

Since there remains "sile" (the previous org name) in many places in the doc, this PR replaces it with "optuna".

[![Actions Status](https://github.com/sile/kurobako/workflows/CI/badge.svg)](https://github.com/sile/kurobako/actions)
[![Coverage Status](https://coveralls.io/repos/github/sile/kurobako/badge.svg?branch=master)](https://coveralls.io/github/sile/kurobako?branch=master)
[![Actions Status](https://github.com/optuna/kurobako/workflows/CI/badge.svg)](https://github.com/optuna/kurobako/actions)
[![Coverage Status](https://coveralls.io/repos/github/optuna/kurobako/badge.svg?branch=master)](https://coveralls.io/github/optuna/kurobako?branch=master)
[![License: MIT](https://img.shields.io/badge/license-MIT-blue.svg)](LICENSE)
[![Docker Hub](https://img.shields.io/badge/docker-ready-blue.svg)](https://hub.docker.com/r/sile/kurobako)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I keep the link untouched in this PR as the docker hub entry "optuna/kurobako" doesn't exist now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's track it here #40.

@sile
Copy link
Member Author

sile commented Jun 24, 2021

This PR also applies minor changes to resolve lint errors: ee00f20

Copy link
Member

@hvy hvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is my understanding correct that the create registry will be updated with the next release? LGTM otherwise!

@@ -11,11 +11,11 @@ pub fn compute(pts: &[Vec<f64>], ref_pt: &[f64]) -> f64 {

fn get_hypervolume_recursive(pts: &[Vec<f64>], ref_pt: &[f64]) -> f64 {
match pts.len() {
1 => get_hypervolume_two_points(&pts[0], &ref_pt),
1 => get_hypervolume_two_points(&pts[0], ref_pt),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hvy hvy merged commit 788dd4c into master Jun 24, 2021
@hvy hvy deleted the fix-doc branch June 24, 2021 06:17
@hvy hvy added this to the 0.2.10 milestone Jun 24, 2021
@sile
Copy link
Member Author

sile commented Jun 24, 2021

Is my understanding correct that the create registry will be updated with the next release?

Yes.
And, I think we don't have to publish the next release immediately just to reflect this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants