Keep only one generation of process cache #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, Kurobako caches all processes that are opened by
ExternalProgramProblemFactory
. This is for reducing the overhead of creating processes and loading datasets.However, this behavior can cause a problem when large datasets are loaded in the children processes. Because Kurobako never closes processes even after those processes become unnecessary, all datasets are eventually loaded on memory and that can eat up all memory on the system.
We propose the following changes that mitigate this issue.
kurobako studies
such that the same command is executed consecutively. This is intended to maximize cache efficiency.