-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use WaveSurfer instead of audio
tag.
#716
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
==========================================
+ Coverage 65.76% 67.20% +1.44%
==========================================
Files 35 35
Lines 2284 2293 +9
==========================================
+ Hits 1502 1541 +39
+ Misses 782 752 -30 ☔ View full report in Codecov by Sentry. |
@contramundum53 Could you review this PR? |
@keisuke-umezawa Could you review this PR? |
There seems to be a problem that the audio is stopped when automatic update runs. |
You're right. The |
I found that we did not need to observe the options of wavesurfer, such as URL of the audio file, since the Optuna artifacts including audio files are not designed to be updated in-place. They are usually removed and re-uploaded instead. I guess we can keep playing the audio now, so please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toshihikoyanase
LGTM! After the purpose of this PR is clear, I will merge it.
Contributor License Agreement
This repository (
optuna-dashboard
) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
A possible follow-up for #629.
What does this implement/fix? Explain your changes.
WaveSurferArtifactViewer
based on the official exampleWaveSurferArtifactViewer
instead ofaudio
tag in the ArtifactCardMedia.tsx