Display conditional parameters properly in TrialTable

[nabenabe0928]

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

• I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

This PR solves issue#734.

What does this implement/fix? Explain your changes.

By this PR, TrialTable can:

1. display conditional parameters appropriately, and
2. filter missing value via filtering.

[codecov]

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (1203501) 68.22% compared to head (c13654f) 69.71%.
Report is 443 commits behind head on main.

Files	Patch %	Lines
optuna_dashboard/artifact/_backend.py	59.45%	15 Missing ⚠️
optuna_dashboard/_app.py	85.71%	5 Missing ⚠️
optuna_dashboard/_serializer.py	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
+ Coverage   68.22%   69.71%   +1.48%     
==========================================
  Files          35       35              
  Lines        2329     2364      +35     
==========================================
+ Hits         1589     1648      +59     
+ Misses        740      716      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[c-bata]

@keisuke-umezawa Could you review this PR?

[c-bata]

Let me assign @porink0424 as an additional reviewer 🙏

[porink0424]

Sure.

[porink0424]

LGTM!

[c-bata]

@keisuke-umezawa Please merge this PR after you approved 🙏

[keisuke-umezawa]

Sorry for being late. I left one comment. Could you check it?

[keisuke-umezawa]

isDynamicSpace is calculated for each study, but filterChoices is set for each column. This isDynamicSpace should be implemented as the value whether the column is dynamic space.

import optuna


def objective(trial):
    category = trial.suggest_categorical("category", ["foo", "bar"])
    if category == "foo":
        return (trial.suggest_float("x1", 0, 10) - 2) ** 2
    else:
        return -((trial.suggest_float("x2", -10, 0) + 5) ** 2)


study = optuna.create_study(storage="sqlite:///test.db")
study.optimize(objective, n_trials=100)

In the above code, this study's isDynamicSpace is always true because some of columns are dynamic spaces. As a result, filterChoices will be filterChoicesWithNull even though category is not dynamic space.

[keisuke-umezawa]

Or, something like this?

const filterChoices =
      s.distribution.type === "CategoricalDistribution"
        ? s.distribution.choices.map((c) => c.value)
        : undefined
values = trials[i].params.find((p) => p.name === s.name)?.param_external_value
if values.contain(null):
    filterChoices.append(null)

[nabenabe0928]

@keisuke-umezawa Thank you for the suggestion, I addressed your point!

[keisuke-umezawa]

LGTM! Thank you for quick fix.