Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using localStorage for reload interval #761

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Jan 19, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

For #719

What does this implement/fix? Explain your changes.

Avoid using localStorage for reload interval to simplify the behavior. Moreover, I removed the code for graph visibility which is actually unused.

@c-bata
Copy link
Member Author

c-bata commented Jan 19, 2024

@nabenabe0928 Could you review this PR?

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6150418) 69.48% compared to head (ce5fe78) 69.48%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #761   +/-   ##
=======================================
  Coverage   69.48%   69.48%           
=======================================
  Files          35       35           
  Lines        2353     2353           
=======================================
  Hits         1635     1635           
  Misses        718      718           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c-bata c-bata merged commit 4464ac5 into optuna:main Jan 19, 2024
10 checks passed
@c-bata c-bata deleted the avoid-using-local-storage branch January 19, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants