Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning in preferential tutorial. #767

Merged

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Jan 24, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

Fixes #765

What does this implement/fix? Explain your changes.

Fix deprecation warning in preferential tutorial.

@c-bata
Copy link
Member Author

c-bata commented Jan 24, 2024

@contramundum53 Could you review this PR?

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (736d2ee) 69.48% compared to head (c1e8ea6) 69.49%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
+ Coverage   69.48%   69.49%   +0.01%     
==========================================
  Files          35       35              
  Lines        2353     2354       +1     
==========================================
+ Hits         1635     1636       +1     
  Misses        718      718              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@contramundum53 contramundum53 merged commit 0cca727 into optuna:main Jan 24, 2024
14 checks passed
@c-bata c-bata deleted the fix-deprecation-warning-system-attrs branch January 24, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation Warning in optuna-dashboard due to deprecated Optuna attribute (study.system_attrs)
2 participants