Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align button design of csv downloader #780

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

keisuke-umezawa
Copy link
Member

@keisuke-umezawa keisuke-umezawa commented Jan 27, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

Fixes #770

What does this implement/fix? Explain your changes.

The new UI becomes the following
スクリーンショット 2024-01-27 14 12 32

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1497505) 69.52% compared to head (33d913d) 69.39%.
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
- Coverage   69.52%   69.39%   -0.13%     
==========================================
  Files          35       35              
  Lines        2359     2369      +10     
==========================================
+ Hits         1640     1644       +4     
- Misses        719      725       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-bata
Copy link
Member

c-bata commented Jan 29, 2024

@eukaryo @HideakiImamura Could you review this PR?

Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the generated download button is appropriate. LGTM.

Screenshot 2024-02-02 at 8 42 16

@HideakiImamura HideakiImamura removed their assignment Feb 1, 2024
@c-bata
Copy link
Member

c-bata commented Feb 2, 2024

Let me merge this PR since already received one approval.

@c-bata c-bata merged commit 281f2da into optuna:main Feb 2, 2024
10 checks passed
@keisuke-umezawa keisuke-umezawa deleted the fix/add-button-csv branch February 5, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the style for "Download CSS File" button
4 participants