Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Preferential] Fix enumerability check in PreferentialGPSampler #797

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

contramundum53
Copy link
Member

@contramundum53 contramundum53 commented Feb 6, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

What does this implement/fix? Explain your changes.

There was a bug in PreferentialGPSampler that cannot correctly check whether the search space was enumerable. This causes #796. I fix this bug.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8c48e7e) 69.13% compared to head (fe00b02) 69.13%.
Report is 14 commits behind head on main.

Files Patch % Lines
optuna_dashboard/_app.py 30.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #797   +/-   ##
=======================================
  Coverage   69.13%   69.13%           
=======================================
  Files          35       35           
  Lines        2378     2388   +10     
=======================================
+ Hits         1644     1651    +7     
- Misses        734      737    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@contramundum53
Copy link
Member Author

The CI will fix with optuna/optuna#5229.

Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the swift fix!

@c-bata c-bata merged commit 9840f2e into main Feb 6, 2024
15 checks passed
@c-bata c-bata deleted the fix-preferential-continuous-check branch February 6, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants