-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partially replace recoil with react-query #801
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #801 +/- ##
==========================================
- Coverage 69.81% 69.71% -0.11%
==========================================
Files 35 35
Lines 2369 2364 -5
==========================================
- Hits 1654 1648 -6
- Misses 715 716 +1 ☔ View full report in Codecov by Sentry. |
Is this PR ready for review? |
Yes, I forgot to put it in the ready state 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great to me 💯
Contributor License Agreement
This repository (
optuna-dashboard
) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Partially replaced recoil states with react-query states for:
studySummary←studySummary
andstudyDetail
are intertwined in implementations, and it is hard for now to replace recoil states regarding onlystudySummary
. So I once abandoned them for now.Careful checks are needed to ensure that cache update timing is as expected 🙏