Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of #632 (Add color scale setting) & #806 (Add "use plotlypy" button) #807

Merged
merged 6 commits into from
Feb 14, 2024

Conversation

porink0424
Copy link
Collaborator

@porink0424 porink0424 commented Feb 14, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

#632 #806

What does this implement/fix? Explain your changes.

This is the follow-up PR of #632 & #806, which includes:

  • Improve the design of the setting modal
  • Change the setting items to be displayed according to the mode
  • Refactor codes

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f718d9) 69.71% compared to head (e609673) 69.71%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #807   +/-   ##
=======================================
  Coverage   69.71%   69.71%           
=======================================
  Files          35       35           
  Lines        2364     2364           
=======================================
  Hits         1648     1648           
  Misses        716      716           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-bata c-bata self-assigned this Feb 14, 2024
@porink0424 porink0424 changed the title Follow up of #632 (Add color scale setting) Follow up of #632 (Add color scale setting) & #806 (Add "use plotlypy" button) Feb 14, 2024
Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@c-bata c-bata merged commit afdb1df into optuna:main Feb 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants