Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise ValueError when given invalid SQLite3 URL #838

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Mar 12, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

Follow-up #800

What does this implement/fix? Explain your changes.

Raise ValueError when given invalid SQLite3 URL.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.60%. Comparing base (652af58) to head (f7359e1).
Report is 3 commits behind head on main.

Files Patch % Lines
optuna_dashboard/_storage_url.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #838   +/-   ##
=======================================
  Coverage   69.60%   69.60%           
=======================================
  Files          35       35           
  Lines        2375     2375           
=======================================
  Hits         1653     1653           
  Misses        722      722           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-bata c-bata merged commit 168301b into optuna:main Mar 12, 2024
13 checks passed
@c-bata c-bata deleted the follow-up-800 branch March 12, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant