Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tslib DataGrid in optuna-dashboard #897

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

keisuke-umezawa
Copy link
Member

@keisuke-umezawa keisuke-umezawa commented Jun 30, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

NA

What does this implement/fix? Explain your changes.

Use tslib DataGrid in optuna-dashboard

@porink0424
Copy link
Collaborator

@keisuke-umezawa
It appears that the error Uncaught Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object. that occurs when importing DataGrid from tslib/react is caused due to the material-ui package. As a workaround, you can use named imports to resolve this:
mui/material-ui#30671 (comment) .

@keisuke-umezawa
Copy link
Member Author

@porink0424
Thank you for the information. I fixed code by your suggestion.

Copy link
Collaborator

@porink0424 porink0424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your fix! LGTM.

@c-bata c-bata merged commit 4ade924 into optuna:main Jul 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants