Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PlotTimeline from optuna_dashboard/ts to tslib/react #951

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

keisuke-umezawa
Copy link
Member

@keisuke-umezawa keisuke-umezawa commented Aug 29, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

NA

What does this implement/fix? Explain your changes.

  • Move PlotTimeline from optuna_dashboard/ts to tslib/react
  • Add stories and tests for PlotSlice

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.00%. Comparing base (9968ab2) to head (cb546a2).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #951   +/-   ##
=======================================
  Coverage   70.00%   70.00%           
=======================================
  Files          35       35           
  Lines        2387     2387           
=======================================
  Hits         1671     1671           
  Misses        716      716           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keisuke-umezawa keisuke-umezawa marked this pull request as ready for review September 20, 2024 05:20
Copy link
Collaborator

@porink0424 porink0424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me! I just left one small comment.

optuna_dashboard/ts/components/GraphTimeline.tsx Outdated Show resolved Hide resolved
keisuke-umezawa and others added 2 commits October 1, 2024 17:00
Co-authored-by: Daichi Kato <83964523+porink0424@users.noreply.github.com>
@keisuke-umezawa
Copy link
Member Author

@porink0424
Sorry for being late. I fixed my code.

Copy link
Collaborator

@porink0424 porink0424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@porink0424 porink0424 merged commit 1a1d22a into optuna:main Oct 11, 2024
10 checks passed
@keisuke-umezawa keisuke-umezawa deleted the feature/add-plottimeline branch October 18, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants