XML support #26
Merged
XML support #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugo-andrade
added
enhancement
|
Hello @Viriathus1! Thank you so much for your contribution to Fast-Shot 🚀! Adding support for XML requests and responses is a fantastic addition, and it will definitely help many users working with this format. I really appreciate the quality of your PR, including the implementation and the thorough unit and integration tests. Your effort is highly valued, and I look forward to seeing more contributions from you in the future. If you have any more ideas or suggestions, I’m always open to discussing them! Thanks again for your time and effort in improving the library 🙏. Best regards, and see you next time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added XML request and response support.
Motivation and Context
Currently working with xml and the library lacks this support.
How Has This Been Tested?
added unit and integration tests
Types of changes
Related Issues:
NA